[PATCH] D58599: [LLD] Add summary support

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: COFF/PDB.cpp:1361
   }
 }
 
----------------
aganea wrote:
> ruiu wrote:
> > aganea wrote:
> > > ruiu wrote:
> > > > Looks like instead of pushing stats data to a `Summary` class and print it out later, you could print out the stats right here.
> > > That would skew profiles recorded for `/time`. I often use `/time` and  `/summary` at the same time.
> > You can stop the timer and resume it after you are done with summary.
> The main selling point was for this to be a one-liner call. However, it's only meant for high-level information, so maybe it won't be that much of an issue for timings.
That's my feeling. Printing out a few lines doesn't seem to affect too much to the statistics of `/time`. I still believe you can just print it out from here.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58599/new/

https://reviews.llvm.org/D58599