[PATCH] D59262: [scudo][standalone] Add string utility functions

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: lib/scudo/standalone/string_utils.cc:24
+
+uptr getStringLengthN(const char *S, uptr MaxLen) {
+  uptr I = 0;
----------------
do you need internal implementation of these functions? Why can't you use libc?
I would expect that scudo has no the same restrictions as sanitizer_common


================
Comment at: lib/scudo/standalone/string_utils.h:24
+
+class ScopedString : public Vector<char> {
+public:
----------------
Could you please switch this to aggregation instead of inheritance?


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59262/new/

https://reviews.llvm.org/D59262