[PATCH] D56675: [lld] add options for context-sensitive PGO.

[Rong Xu via Phabricator via llvm-commits]

xur added a comment.

In D56675#1426458 <https://reviews.llvm.org/D56675#1426458>, @dmajor wrote:

> Are there any bugs/reviews/etc. that I can subscribe to for the implementation of this in COFF?


Feature of the main implementation is reviewed here:
https://reviews.llvm.org/D54175
The change has been committed.

I'm not familiar with COFF. But I think you can just do similar things as in ELF: it just passes the plugin-opts to backend compilation.



================
Comment at: ELF/Options.td:440-443
+def lto_cs_pgo_gen: F<"lto-cs-pgo-gen">,
+  HelpText<"Perform context senstive PGO instrumentation">;
+def lto_cs_profile_file: J<"lto-cs-profile-file=">,
+  HelpText<"Context sensitive profile file path">;
----------------
ruiu wrote:
> Are these new options, or is there a linker that already have these options? If they are new, is there any reason to choose a new name `lto-cs-pgo-gen` instead of `lto-cs-profile-generate`?
They are new options. I will change the name to -lto-cs-profile-generate.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56675/new/

https://reviews.llvm.org/D56675