[PATCH] D59216: [LLD][ELF][ARM] Redesign of .ARM.exidx handling to use a SyntheticSection

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

Just a few nits about coding style from me.



================
Comment at: ELF/SyntheticSections.cpp:3093
+      Empty = false;
+    } else
+      Size += 8;
----------------
I think LLD style would be to use `{`, `}`:

```
else {
  Size += 8;
}
```


================
Comment at: ELF/SyntheticSections.cpp:3098
+  Size += 8;
+}
+
----------------
Will it be better to do `Size = 8;` from start?


================
Comment at: ELF/SyntheticSections.cpp:3136
+    return PrevEntry.Unwind == ulittle32_t(1);
+  }
+
----------------
No need to use curly bracers.


================
Comment at: ELF/SyntheticSections.cpp:3217
+    } else {
+      // A Linker generated CANTUNWIND section
+      memcpy(Buf + Offset, CantUnwindData, sizeof(CantUnwindData));
----------------
Comments in LLD usually ends with a full stop.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59216/new/

https://reviews.llvm.org/D59216