[PATCH] D59251: [Documentation] Proposal for plan to change variable names

[Tim Northover via Phabricator via llvm-commits]

t.p.northover added inline comments.


================
Comment at: llvm/docs/Proposals/VariableNames.rst:46-47
+
+  InnerLoopVectorizer LB(L, PSE, LI, DT, TLI, TTI, AC, ORE, VF.Width, IC,
+                         &LVL, &CM);
+
----------------
WTF!


================
Comment at: llvm/docs/Proposals/VariableNames.rst:133
+
+The following is a list of acronyms considered sufficiently useful that the
+benefit of using them outweighs the cost of learning them. Acronyms that are
----------------
How was this list derived? It seems a bit skewed towards mid-end development over back-end.

`MRI` is `MachineRegisterInfo` to me (and about 70% of LLVM code by a quick grep); and `TLI` is `TargetLoweringInfo` (rarer than TargetLibraryInfo this time, but still about 30% of uses).

I know someone specifically mentioned being surprised by conflicting acronyms when moving to different parts of LLVM, but I think it's rare enough that we should still allow them.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59251/new/

https://reviews.llvm.org/D59251