[PATCH] D59256: [ARM] Disable LDM with offset for thumb2 cortex-m cpus

Tim Northover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 12 08:09:50 PDT 2019


t.p.northover added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMLoadStoreOptimizer.cpp:677
+    // On M class cores, the extra add will only increase latency
+    if (STI->isMClass() && !isThumb1 && !MF->getFunction().optForSize())
+      return nullptr;
----------------
I think the check should be `optForMinSize`. Clang interprets -Os in a more performance-oriented way than GCC; something like "don't needlessly bloat code". -Oz is the real option to squash everything as much as possible.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59256/new/

https://reviews.llvm.org/D59256





More information about the llvm-commits mailing list