[PATCH] D59243: [format] \t => ' '

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 12 03:03:31 PDT 2019


kristina added a comment.

Hi,

Please make sure to specify `Differential Revision: https://reviews.llvm.org/D59243` with `Dxxxxx` being the differential number in the URL when committing (on a separate line in the commit message) which will autmatically close the differential and link it to the commit which makes sure there are no stray/stale differentials. Alternatively manually link the diff to the commit (you can do that by simply quoting the commit as `rL<SVN Rev>` and then closing the differential manually.

Also, for future NFC patches, usually very minor formatting patches or spelling fixes don't really require a review, however please make sure to specify the purpose of the patch and mention `NFC` or `NFCI` in the title (indicating `No Functional Change (Intended)`) which makes the patch intention clear. Phabricator is mostly a code review platform so extremely minor corrections in comments or indentation usually don't need review.

You can find more information regarding the submission process here: http://llvm.org/docs/Contributing.html (as well as the developer policy here:  http://llvm.org/docs/DeveloperPolicy.html).

Thank you.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59243/new/

https://reviews.llvm.org/D59243





More information about the llvm-commits mailing list