[PATCH] D59153: [MBP] Make sure the exit BB is the most possible successor before rotating a loop

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:1871
+bool
+MachineBlockPlacement::isBestPred(const MachineBasicBlock *Succ,
+                                  const MachineBasicBlock *MBB) {
----------------
loop rotation can save one internal fall through, not just adding a loop exit fall through. Do you need to consider the overall cost/savings?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59153/new/

https://reviews.llvm.org/D59153