[PATCH] D58928: [AMDGPU] Prepare for introduction of v3 and v5 MVTs
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 11 18:32:04 PDT 2019
arsenm added a comment.
In D58928#1424393 <https://reviews.llvm.org/D58928#1424393>, @tpr wrote:
> In D58928#1418559 <https://reviews.llvm.org/D58928#1418559>, @arsenm wrote:
>
> > Could also use the vector tests for the shader arguments
>
>
> Could you explain what you're suggesting I do please?
You added tests for kernel arguments, but the calling convention lowering path is quite different for regular functions as well as shaders. The tests for the othercalling convention argument types should also be tested. V3 may already be tested, but v5 probably is not
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58928/new/
https://reviews.llvm.org/D58928
More information about the llvm-commits
mailing list