[PATCH] D59170: [lld] [ELF] Print a better error for an archive containing a non-ELF file.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 11 17:58:41 PDT 2019


ruiu added inline comments.


================
Comment at: ELF/InputFiles.cpp:1198
     StringRef Filename = MB.getBufferIdentifier();
+    StringRef MsgPrefix = NotElf ? ": " : ": corrupted ELF file: ";
     if (ArchiveName.empty())
----------------
Perhaps this is a bit too complicated for this tiny utility function? I'd add "corrupted ELF file: " to the beginning of each existing error message instead.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59170/new/

https://reviews.llvm.org/D59170





More information about the llvm-commits mailing list