[PATCH] D58858: [msan] Instrument x86 BMI intrinsics.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis marked an inline comment as done.
eugenis added a comment.

This is expected to break. I'm surprised it did not break earlier - we often do a compiler change and corresponding integration tests in compiler-rt as a single commit, or two consecutive commits.



================
Comment at: lib/msan/tests/msan_test.cc:4653
+  const U4 kBmi12Mask = (1U<<3) | (1U<<8);
+  return b | kBmi12Mask;
+#else
----------------
Hahnfeld wrote:
> Shouldn't this be `return b & kBmi12Mask`? The current expression should always cast to `true`...
Of course! Will fix.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58858/new/

https://reviews.llvm.org/D58858