[PATCH] D35985: Skip live range segment verification for reserved physregs

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan added inline comments.


================
Comment at: lib/CodeGen/RegisterCoalescer.cpp:1881-1882
 
+  for (MCRegUnitIterator UI(DstReg, TRI); UI.isValid(); ++UI)
+    LIS->removeRegUnit(*UI);
+
----------------
arsenm wrote:
> This is the same as LIS::removeAllRegUnitsForPhysReg I recently added.
> 
> Can you assert all the regunits here are reserved?
Good point. Adding the `assert(MRI->isReservedRegUnit(*UI)` to the loop causes crashes. The last register unit in a list is not reserved. I need to investigate that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D35985/new/

https://reviews.llvm.org/D35985