[PATCH] D56675: [lld] add options for context-sensitive PGO.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Sorry for the belated response. (I was on vacation last week.)



================
Comment at: ELF/Driver.cpp:801-802
   Config->LTOAAPipeline = Args.getLastArgValue(OPT_lto_aa_pipeline);
+  Config->LTOCSProfileFile = Args.getLastArgValue(OPT_lto_cs_profile_file);
+  Config->LTOCSPGOGen = Args.hasArg(OPT_lto_cs_pgo_gen);
   Config->LTODebugPassManager = Args.hasArg(OPT_lto_debug_pass_manager);
----------------
Please sort ASCIIbetically.


================
Comment at: ELF/Options.td:440-443
+def lto_cs_pgo_gen: F<"lto-cs-pgo-gen">,
+  HelpText<"Perform context senstive PGO instrumentation">;
+def lto_cs_profile_file: J<"lto-cs-profile-file=">,
+  HelpText<"Context sensitive profile file path">;
----------------
Are these new options, or is there a linker that already have these options? If they are new, is there any reason to choose a new name `lto-cs-pgo-gen` instead of `lto-cs-profile-generate`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56675/new/

https://reviews.llvm.org/D56675