[llvm] r355646 - Work around a module build error on the LLDB incremental green dragon bot.

[Adrian Prantl via llvm-commits]

You'll see the sad resolution of this two commits further down. (I reverted this one, too). There was a header file with a function body that used the LLVM_DEBUG macro (which I believe fundamentally cannot work inside a non-textual header) and inside of it it called a dump method, thus pulling the reference to the dump method into the link.

-- adrian

> On Mar 11, 2019, at 1:56 PM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> 
> 
> On Thu, Mar 7, 2019 at 2:24 PM Adrian Prantl via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
> Author: adrian
> Date: Thu Mar  7 14:25:26 2019
> New Revision: 355646
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=355646&view=rev <http://llvm.org/viewvc/llvm-project?rev=355646&view=rev>
> Log:
> Work around a module build error on the LLDB incremental green dragon bot.
> 
> Modified:
>     llvm/trunk/include/llvm/module.modulemap
> 
> Modified: llvm/trunk/include/llvm/module.modulemap
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/module.modulemap?rev=355646&r1=355645&r2=355646&view=diff <http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/module.modulemap?rev=355646&r1=355645&r2=355646&view=diff>
> ==============================================================================
> --- llvm/trunk/include/llvm/module.modulemap (original)
> +++ llvm/trunk/include/llvm/module.modulemap Thu Mar  7 14:25:26 2019
> @@ -353,6 +353,10 @@ module LLVM_Utils {
>      exclude header "Support/PluginLoader.h"
>      exclude header "Support/Solaris/sys/regset.h"
> 
> +    // FIXME: The function bodies in this header pull in
> +    //        unwanted dependencies that cause linker errors.
> 
> What does it pull in & how does it cause linker errors?
>  
> +    exclude header "Support/GenericDomTreeConstruction.h"
> +
>      // These are intended for textual inclusion.
>      textual header "Support/ARMTargetParser.def"
>      textual header "Support/AArch64TargetParser.def"
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190311/e69a0851/attachment.html>