[PATCH] D59228: Fix typos in compiler-rt/lib/builtins/atomic.c

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added a comment.

This leaves me wondering where the tests for this file are.



================
Comment at: compiler-rt/lib/builtins/atomic.c:137
   do {\
   switch (size) {\
     case 2:\
----------------
Is `IS_LOCK_FREE_1` omitted on purpose?


================
Comment at: compiler-rt/lib/builtins/atomic.c:142
       }\
+      break; \
     case 4:\
----------------
The `LOCK_FREE_ACTION` is not supposed to fall-through to here. I am not sure the change is helpful (and it may reduce the ability of compiler warnings to catch bad definitions of `LOCK_FREE_ACTION`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59228/new/

https://reviews.llvm.org/D59228