[PATCH] D58690: [AArch64] Add code size information on isFPImmLegal
Evandro Menezes via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 11 13:50:31 PDT 2019
evandro added inline comments.
================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:5407
IsLegal = AArch64_AM::getFP16Imm(ImmInt) != -1 || Imm.isPosZero();
// TODO: fmov h0, w0 is also legal, however on't have an isel pattern to
// generate that fmov.
----------------
zatrazz wrote:
> evandro wrote:
> > Oops!
> Hi Evandro, I am not following your remarks. At least on phabricator they are pointing on code section that has not been actually changed. Should I submit the patch again?
I don't know what Phabricator showed me before either. Please, ignore my previous review. I'll go over the patch again.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58690/new/
https://reviews.llvm.org/D58690
More information about the llvm-commits
mailing list