[PATCH] D58832: [SampleFDO] add suffix elision control for fcn names

Than McIntosh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 11 13:19:52 PDT 2019


thanm marked 4 inline comments as done.
thanm added inline comments.


================
Comment at: include/llvm/ProfileData/SampleProfReader.h:289-290
   FunctionSamples *getSamplesFor(const Function &F) {
     // The function name may have been updated by adding suffix. In sample
     // profile, the function names are all stripped, so we need to strip
     // the function name suffix before matching with profile.
----------------
wmi wrote:
> Now that the function names are not necessarily all stripped, we want to update the comment accordingly. 
I've updated the comment.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58832/new/

https://reviews.llvm.org/D58832





More information about the llvm-commits mailing list