[PATCH] D59222: MIR: Stop reinitializing target information for every use

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 11 13:00:20 PDT 2019


thegameg accepted this revision.
thegameg added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: lib/CodeGen/MIRParser/MIRParser.cpp:56
   SlotMapping IRSlots;
-  /// Maps from register class names to register classes.
-  Name2RegClassMap Names2RegClasses;
-  /// Maps from register bank names to register banks.
-  Name2RegBankMap Names2RegBanks;
+  std::unique_ptr<PerTargetMIParsingState> Target;
+
----------------
nit: `Optional<PerTargetMIParsingState>`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59222/new/

https://reviews.llvm.org/D59222





More information about the llvm-commits mailing list