[PATCH] D59126: llvm-objcopy: Remove unused field. NFCI.

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added a comment.

So this change and the issue that James hit made me think about a few short comings in llvm-objcopy that I think should be addressed.

1. Consider the issue of data in a PT_LOAD that isn't covered by a section. We should maintain that IMO.
2. Consider the issue of added trap instructions that LLD adds. Right now we're not preserving that and thus stripping decreases the security of binaries produced by LLD
3. --strip-sections really should strip all sections, not just the allocated ones

I think soon we'll have to start copying from segments, when a section doesn't cover the region.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59126/new/

https://reviews.llvm.org/D59126