[PATCH] D59016: [TableGen] Allow 2^63-1 and 2^63-2 as int literals.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 11 11:09:47 PDT 2019


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

TableGen is not very performance sensitive; it's fine to just do the simple thing here.

DenseMap is generally faster than std::map both because it's a hashtable and because it allocates the keys and values inline... but clearly it's not a good idea to use it when it produces wrong results.  Longer-term, we should probably come up with some alternative that has performance like a DenseMap, but doesn't misbehave for cases like this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59016/new/

https://reviews.llvm.org/D59016





More information about the llvm-commits mailing list