[PATCH] D58829: Do a sign-extension in a compare-and-swap of 32 bit in RV64A

[Ferran Pallarès Roca via Phabricator via llvm-commits]

fpallares updated this revision to Diff 190120.
fpallares added a comment.

Thank you. I've updated the test using 'update_llc_test_checks.py' and I've added a comment as suggested.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58829/new/

https://reviews.llvm.org/D58829

Files:
  lib/Target/RISCV/RISCVISelLowering.h
  test/CodeGen/RISCV/atomic-cmpxchg-flag.ll


Index: test/CodeGen/RISCV/atomic-cmpxchg-flag.ll
===================================================================
--- /dev/null
+++ test/CodeGen/RISCV/atomic-cmpxchg-flag.ll
@@ -0,0 +1,29 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=riscv64 -mattr=+a -verify-machineinstrs < %s \
+; RUN:   | FileCheck -check-prefix=RV64IA %s
+
+; This test ensures that the output of the 'lr.w' instruction is sign-extended.
+; Previously, the default zero-extension was being used and 'cmp' parameter
+; higher bits were masked to zero for the comparison.
+
+define i1 @cmpxchg_i32_seq_cst_seq_cst(i32* %ptr, i32 signext %cmp,
+        i32 signext %val) {
+; RV64IA-LABEL: cmpxchg_i32_seq_cst_seq_cst:
+; RV64IA:       # %bb.0: # %entry
+; RV64IA-NEXT:  .LBB0_1: # %entry
+; RV64IA-NEXT:    # =>This Inner Loop Header: Depth=1
+; RV64IA-NEXT:    lr.w.aqrl a3, (a0)
+; RV64IA-NEXT:    bne a3, a1, .LBB0_3
+; RV64IA-NEXT:  # %bb.2: # %entry
+; RV64IA-NEXT:    # in Loop: Header=BB0_1 Depth=1
+; RV64IA-NEXT:    sc.w.aqrl a4, a2, (a0)
+; RV64IA-NEXT:    bnez a4, .LBB0_1
+; RV64IA-NEXT:  .LBB0_3: # %entry
+; RV64IA-NEXT:    xor a0, a3, a1
+; RV64IA-NEXT:    seqz a0, a0
+; RV64IA-NEXT:    ret
+entry:
+  %0 = cmpxchg i32* %ptr, i32 %cmp, i32 %val seq_cst seq_cst
+  %1 = extractvalue { i32, i1 } %0, 1
+  ret i1 %1
+}
Index: lib/Target/RISCV/RISCVISelLowering.h
===================================================================
--- lib/Target/RISCV/RISCVISelLowering.h
+++ lib/Target/RISCV/RISCVISelLowering.h
@@ -106,6 +106,10 @@
   Instruction *emitTrailingFence(IRBuilder<> &Builder, Instruction *Inst,
                                  AtomicOrdering Ord) const override;
 
+  ISD::NodeType getExtendForAtomicOps() const override {
+    return ISD::SIGN_EXTEND;
+  }
+
 private:
   void analyzeInputArgs(MachineFunction &MF, CCState &CCInfo,
                         const SmallVectorImpl<ISD::InputArg> &Ins,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58829.190120.patch
Type: text/x-patch
Size: 1960 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190311/4e0abe60/attachment.bin>