[PATCH] D58984: DAG: propagate ConsecutiveRegs flags to returns too.

[Tim Northover via Phabricator via llvm-commits]

t.p.northover marked an inline comment as done.
t.p.northover added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:1643
 
+      bool NeedsRegBlock = TLI.functionArgumentNeedsConsecutiveRegisters(
+          I.getOperand(0)->getType(), F->getCallingConv(),
----------------
arsenm wrote:
> The hook name is inaccurate here. Maybe there should be an alias for it for the return value?
I don't think it merits two separate callbacks, returns and parameters are basically the same thing and I'd rather bend the meaning of "argument" if it comes down to it. It's not even really a change to existing practice: `OutputArg` and `ArgFlagsTy` are already used in visitRet.

I did put the code actually using this variable into the wrong patch though. I'll upload a new version to fix that and add context while we muse on this.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58984/new/

https://reviews.llvm.org/D58984