[PATCH] D59175: [llvm-readobj] Print symbol version when dumping relocations (PR31564)

Xing via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 11 06:07:35 PDT 2019


Higuoxing marked an inline comment as done.
Higuoxing added inline comments.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:2719
     StringRef StrTable = unwrapOrError(Obj->getStringTableForSymtab(*SymTab));
-    TargetName = maybeDemangle(unwrapOrError(Sym->getName(StrTable)));
+    TargetName = this->dumper()->getFullSymbolName(
+        Sym, StrTable, SymTab->sh_type == SHT_DYNSYM);
----------------
grimar wrote:
> Seems you do not need `this->`
Sorry, I cannot remove `this`, I cannot find another way to achieve this.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59175/new/

https://reviews.llvm.org/D59175





More information about the llvm-commits mailing list