[PATCH] D59130: [llvm][Support] Provide interface to set thread priorities
Kadir Cetinkaya via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 11 04:03:46 PDT 2019
kadircet added a comment.
In D59130#1422858 <https://reviews.llvm.org/D59130#1422858>, @jfb wrote:
> None of these check the return value of the priority calls. What's expected if it fails?
We can change it to return true on success and false on failure.
> Do these actually give the same semantics? I'm worried that this will get used and on some platforms a thread might stop doing progress at all whereas on other platforms they'll still make progress. What's the intended use of this?
These are the functions with closest semantics in those three platforms. It tries to lower thread's priority such that it only runs if there's no non-background task running.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59130/new/
https://reviews.llvm.org/D59130
More information about the llvm-commits
mailing list