[PATCH] D59097: [yaml2obj]Lookup relocation symbols in dynamic symbol when .dynsym referenced

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 11 01:18:26 PDT 2019


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: tools/yaml2obj/yaml2elf.cpp:868
+                              Doc.DynamicSymbols.Weak))
     return 1;
 
----------------
This place looks a bit overcomplicated (seems requires refactoring), but it is not a problem of this patch.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59097/new/

https://reviews.llvm.org/D59097





More information about the llvm-commits mailing list