[PATCH] D59187: [AArch64] Turn BIC creation into a DAG combine

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 10 14:22:21 PDT 2019


efriedma added a comment.

I agree it doesn't really make sense to custom-lower this operation.  That said, off the top of my head, I'm not sure why we're doing this at the DAG level at all, given the available instructions; it should be possible to pattern match `(and x, (mvni imm))` during isel.  (If there's some reason that doesn't work, a brief comment explaining it would be helpful.)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59187/new/

https://reviews.llvm.org/D59187





More information about the llvm-commits mailing list