[PATCH] D59193: [ConstantRange] Add overflow check helpers

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 10 14:03:32 PDT 2019


nikic added a comment.

In D59193#1424028 <https://reviews.llvm.org/D59193#1424028>, @lebedev.ri wrote:

> This looks extremely error prone.
>  This needs to be verified (keywords: alive, SMT) somehow ideally.


Maybe I can just include some exhaustive tests? I'm thinking on 4-bit numbers we have 16^2 possible ranges with less than 16^4 values contained in them in total. That's few enough to try all of them.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59193/new/

https://reviews.llvm.org/D59193





More information about the llvm-commits mailing list