[PATCH] D58858: [msan] Instrument x86 BMI intrinsics.

[Jonas Hahnfeld via Phabricator via llvm-commits]

Hahnfeld added a comment.

The added test is failing for me because I'm building (and testing) `compiler-rt` with Clang 7 which doesn't instrument BMI, and I'd assume the same with Clang 8 once released. Is that an oversight or is this configuration expected to break?



================
Comment at: lib/msan/tests/msan_test.cc:4653
+  const U4 kBmi12Mask = (1U<<3) | (1U<<8);
+  return b | kBmi12Mask;
+#else
----------------
Shouldn't this be `return b & kBmi12Mask`? The current expression should always cast to `true`...


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58858/new/

https://reviews.llvm.org/D58858