[PATCH] D58832: [SampleFDO] add suffix elision control for fcn names

[Wei Mi via Phabricator via llvm-commits]

wmi added a comment.

In D58832#1423171 <https://reviews.llvm.org/D58832#1423171>, @thanm wrote:

> In D58832#1422205 <https://reviews.llvm.org/D58832#1422205>, @wmi wrote:
>
> > We need function attribute only when we want to use different strategies for different functions. Do we need the function granularity control over the suffix elision policy?
>
>
> We want to be able to eventually support ThinLTO in which you have a mix of C and Go functions (it is fairly common for Go programs to call out into C code).   Without such a change we'd have to pick one policy or another and hope that it works for code generated by every front end.


That makes sense to me. Thanks for explaining.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58832/new/

https://reviews.llvm.org/D58832