[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

[David Salinas via Phabricator via llvm-commits]

david-salinas added a comment.

This change has caused a regression for generic C++.  Should this affect OpenCL only?

The following simple test causes the diagnostic to be emitted:

#define ATTR_GLOBAL __attribute__((address_space(1)))

int calc(int ATTR_GLOBAL *ip) {

  int i = *ip;
  return i+1;

}

int main() {

  int i = 99;
  int *ip = &i;
  
  auto *g_i_ptr = reinterpret_cast<int  ATTR_GLOBAL*>(ip);
  return calc(g_i_ptr);

}


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58346/new/

https://reviews.llvm.org/D58346