[PATCH] D59127: [CMake] Support stripping and linking output to .build-id directory

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 8 13:29:27 PST 2019


smeenai accepted this revision.
smeenai added a comment.

Build parts look good to me.



================
Comment at: llvm/cmake/modules/LLVMExternalProjectUtils.cmake:38
 #     Extra variable prefixes (name is always included) to pass down
+#   USE_STRIP path
+#     Use provided strip tool/script instead of the default one.
----------------
I think `STRIP_TOOL` or `STRIP_PATH` or `STRIP_TOOL_PATH` would be more standard, but I don't care too much.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59127/new/

https://reviews.llvm.org/D59127





More information about the llvm-commits mailing list