[PATCH] D59116: [scudo][standalone] Implement checksumming functions

Fri Mar 8 12:11:15 PST 2019

cryptoad added a comment.

In D59116#1422986 <https://reviews.llvm.org/D59116#1422986>, @eugenis wrote:

> Could this be done with a target("sse4.2") function attribute instead of cmake conditions?

I have had no success with early tries with attribute target, mostly due to discrepancies between clang & gcc (depending on versions). Like target("+crc") doesn't seem to work with my clangs (https://gcc.gnu.org/onlinedocs/gcc/ARM-Function-Attributes.html).
Additional concern about this is the resolver function that is used on every invocation of the function (at least with g++).
While this could be addressed with a function pointer, I am trying to avoid a writable function pointer in a critical path of the allocator as it could be leveraged for exploitation purposes.

Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59116/new/

https://reviews.llvm.org/D59116