[PATCH] D58960: [llvm-objcopy] - Fix --compress-debug-sections when there are relocations.

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added a comment.

This looks good to me but it is perhaps confusing that the replaceSectionReferences method is unimplemented for many types where it makes sense. Implementing it for all types makes --only-keep-debug possible for instance.



================
Comment at: tools/llvm-objcopy/ELF/Object.h:284
+  virtual void
+  replaceSectionReferences(const DenseMap<SectionBase *, SectionBase *> &);
 };
----------------
Nice! This has actually been a blocker for correctly implementing --only-keep-debug anyhow.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58960/new/

https://reviews.llvm.org/D58960