[PATCH] D59023: [RISCV] Support -target-abi at the MC layer and for codegen

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 8 10:35:20 PST 2019


asb added inline comments.


================
Comment at: lib/Target/RISCV/RISCVSubtarget.cpp:42
+  if (Expected<RISCVABI::ABI> ABIOrError =
+          RISCVABI::computeTargetABI(TT, getFeatureBits(), ABIName))
+    TargetABI = ABIOrError.get();
----------------
apazos wrote:
> Now it always returns a valid ABI, right? Do we need this check?
Meant to remove this, thanks for catching.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59023/new/

https://reviews.llvm.org/D59023





More information about the llvm-commits mailing list