[PATCH] D54043: Adding debug info to support Fortran (part 1)

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

I'd be inclined to add the serialize/deserialize test to an existing test file, rather than a new test.
Similarly for the flag->attribute test.



================
Comment at: test/DebugInfo/Generic/fortran-subprogram-at.ll:2
+; Test for DIFlagPure, DIFlagElement and DIFlagRecursive. These three
+; DIFlags are used to attach DW_AT_pure, DW_AT_element, and DW_AT_recursive
+; attributes to DW_TAG_subprogram DIEs.
----------------
s/DIFlag/DISPFlag/ in the comments.  Also might be worth noting that the test is for serializing/de-serializing the flags (as opposed to the semantic effect).


================
Comment at: test/DebugInfo/Generic/more-subprogram-attr.ll:13
+; CHECK:   DW_AT_elemental [DW_FORM_flag_present] (true)
+; CHECK:   DW_AT_recursive [DW_FORM_flag_present] (true)
+
----------------
Maybe make these three use CHECK-DAG?
Then add `CHECK: {{DW_TAG|NULL}}` after, which ensures they're all attached to the same DIE.

Arguably the test should verify each flag individually, i.e. on separate functions, but I'll leave that up to you.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54043/new/

https://reviews.llvm.org/D54043