[PATCH] D54043: Adding debug info to support Fortran (part 1)

[Eric Schweitz via Phabricator via llvm-commits]

schweitz updated this revision to Diff 189865.
schweitz added a comment.
Herald added a subscriber: ormris.

Rework of D54043 <https://reviews.llvm.org/D54043> to use the DISPFlag* enum added afterward.

      

FWIW:
In porting, I discovered that mixing the old metadata syntax with the new DISPFlag values is problematic (or, at least, doesn't give a very clear error message).  Specifically, if one has a 'isDefinition: true' combined with 'spFlags: DISPFlagRecursive', it will cause the IR Verifier to fail. Using 'spFlags: DISPFlagDefinition | DISPFlagRecursive' and omitting 'isDefinition:' got around this issue.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54043/new/

https://reviews.llvm.org/D54043

Files:
  include/llvm/IR/DebugInfoFlags.def
  include/llvm/IR/DebugInfoMetadata.h
  lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  test/DebugInfo/Generic/fortran-subprogram-at.ll
  test/DebugInfo/Generic/more-subprogram-attr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54043.189865.patch
Type: text/x-patch
Size: 5421 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190308/cbc60a71/attachment.bin>