[PATCH] D59024: [CGP] Limit distance between overflow math and cmp

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 8 05:46:35 PST 2019


spatel added a comment.

In D59024#1422562 <https://reviews.llvm.org/D59024#1422562>, @dmgreen wrote:

> Hello. I think the idea of this sounds sensible, to limit things if the instruction are too far apart, I'm just not sure of using domtree's to do that.


This is a hack, but given that this code has been shown to be compile-time sensitive: what if we limit the transform to cases where the instructions are in the same block or a direct predecessor block? IIUC, that would prevent the transform for the motivating cases here, but not affect any of the existing tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59024/new/

https://reviews.llvm.org/D59024





More information about the llvm-commits mailing list