[PATCH] D59095: [llvm-readelf]Don't lose negative-ness of negative addends for no symbol relocations
Xing via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 8 03:08:02 PST 2019
Higuoxing added inline comments.
================
Comment at: tools/llvm-readobj/ELFDumper.cpp:3401
+ }
+ Addend += to_string(format_hex_no_prefix(RelAddend, 1));
}
----------------
jhenderson wrote:
> Higuoxing wrote:
> > Can we use `to_hexString(RelAddend, false)` here? I think it's better to have consistent code style.
> Would you mind if I do this in a later patch? I'm looking to try to share the code for `printRelocation` and `printDynamicRelocation`, since they're almost identical anyway, and this would be one of the changes I'm planning on then.
Never mind :)
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59095/new/
https://reviews.llvm.org/D59095
More information about the llvm-commits
mailing list