[PATCH] D59014: [TTI] Enable analysis of clib functions in getIntrinsicCosts. NFCI.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer marked an inline comment as done.
SjoerdMeijer added inline comments.


================
Comment at: include/llvm/Analysis/TargetTransformInfo.h:217
   /// being called in the event it is a library call with special lowering.
-  int getCallCost(const Function *F, int NumArgs = -1) const;
+  int getCallCost(const Function *F, int NumArgs = -1, User *U = nullptr) const;
 
----------------
dmgreen wrote:
> I may be missing something.. but where is this one defined? The changes in TargetTransformInfo.cpp only have two getCallCost functions.
Thanks for spotting this one.
The story here is indeed that we don't have a definition for this one, which is of course odd. I propose changing it here anyway to also have a const User *U argument, just for consistency reasons. If we would like to remove this declaration, then we can do that in separate patch. If (downstream) users have a problem with that, this patch is unaffected and I don't need to change it again.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59014/new/

https://reviews.llvm.org/D59014