[PATCH] D59095: [llvm-readelf]Don't lose negative-ness of negative addends for no symbol relocations

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 7 22:59:07 PST 2019


MaskRay added inline comments.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:2735
+        Addend = " - ";
+        RelAddend = std::abs(RelAddend);
+      } else
----------------
If `r_addend = LLONG_MIN`, `abs(r_addend)` is ub...

"The behavior is undefined if the result cannot be represented by the return type."


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59095/new/

https://reviews.llvm.org/D59095





More information about the llvm-commits mailing list