[PATCH] D59071: [Transform] Improve saddo with mixed signs

Dan Robertson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 7 17:38:00 PST 2019


dlrobertson added a comment.

In D59071#1421411 <https://reviews.llvm.org/D59071#1421411>, @nikic wrote:

> I'm thinking that we should generalize that code to take any Instruction, move it as an exported API into ValueTracking and then do a generic ConstantRange based always/never overflow check here.


So do you mean update the `computeKnownBitsFromOperator` for `sadd_with_overflow` to also take into account the overflow flag?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59071/new/

https://reviews.llvm.org/D59071





More information about the llvm-commits mailing list