[PATCH] D59119: [SelectionDAG] Check legality for ADDCARRY in expandMUL_LOHI

[Leonard Chan via Phabricator via llvm-commits]

leonardchan created this revision.
leonardchan added reviewers: ebevhan, bjope, craig.topper, RKSimon.
leonardchan added a project: LLVM.
Herald added a subscriber: hiraditya.

Add a check for this operation since for X86, it is only supported for 64 bit targets according to the FIXME in `X86ISelLowering.cpp`:

  // Only custom-lower 64-bit SADDO and friends on 64-bit because we don't
  // handle type legalization for these operations here.
  //
  // FIXME: We really should do custom legalization for addition and
  // subtraction on x86-32 once PR3203 is fixed.  We really can't do much better
  // than generic legalization for 64-bit multiplication-with-overflow, though.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D59119

Files:
  llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
  llvm/test/CodeGen/X86/smul_fix.ll
  llvm/test/CodeGen/X86/umul_fix.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59119.189801.patch
Type: text/x-patch
Size: 21525 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190308/0e8be193/attachment.bin>