[PATCH] D59068: [coroutines][PR40979] Ignore unreachable uses across suspend points
Gor Nishanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 7 13:13:34 PST 2019
GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
LGTM with a tiny suggestion
================
Comment at: lib/Transforms/Coroutines/CoroSplit.cpp:931
F->removeFnAttr(CORO_PRESPLIT_ATTR);
+ EliminateUnreachableBlocks(*F);
splitCoroutine(*F, CG, SCC);
----------------
I suggest to move it inside of the splitCoroutine function.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59068/new/
https://reviews.llvm.org/D59068
More information about the llvm-commits
mailing list