[PATCH] D59062: [GlobalISel][AArch64] Always fall back on aarch64.neon.addp.*

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 7 11:29:38 PST 2019


arsenm added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/LegalizerInfo.cpp:81-84
+  // If the user wants a custom mutation, then we can't really say much about
+  // it. Return true, and trust that they're doing the right thing.
+  if (Rule.getAction() == Custom)
+    return true;
----------------
Why is this necessary? This should hit the default in the switch. You could alternatively add an explicit case if you want to keep the comment


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59062/new/

https://reviews.llvm.org/D59062





More information about the llvm-commits mailing list