[PATCH] D58956: [WebAssembly] Remove tabs in tests (NFC)

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 7 11:23:54 PST 2019


sbc100 added a comment.

In D58956#1421823 <https://reviews.llvm.org/D58956#1421823>, @aardappel wrote:

> It would be awesome if we could somehow force tabs to be errors, frankly. Or is there some other automatic way to detect them? Or show them in code review?
>
> I know this changes is abandoned, but I am in favor of it.


But what about then the tabs form part of the program under test's output?   Whats that argument against allowing them?   Surely it makes it easier if one can (or at least has the option to) simply copy and paste the expectations?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58956/new/

https://reviews.llvm.org/D58956





More information about the llvm-commits mailing list