[PATCH] D59007: [WebAssembly] Use named operands to identify loads and stores

[Heejin Ahn via Phabricator via llvm-commits]

aheejin accepted this revision.
aheejin added a comment.
This revision is now accepted and ready to land.

LGTM w/ a comment question.



================
Comment at: llvm/test/CodeGen/WebAssembly/bulk-memory.ll:147
+; 10 because in non-leaf function it must be 16-byte aligned, and
+; there is no special case for leaf functions.
+
----------------
tlively wrote:
> aheejin wrote:
> > - This sentence sounds like `__stack_pointer` global itself is bumped to a new location, which actually happens in non-leaf functions. But here we only read it to compute the frame index and don't modify `__stack_pointer` itself..?
> > - "in non-leaf function it must be 16-byte aligned, and there is no special case for leaf functions.": Why is it 16 bytes aligned and why is there no special case for leaf functions?
> Updated to reflect my findings from investigating `TransientStackAlignment`.
The comment still says "stack_pointer is bumped". What I meant was `__stack_pointer` is NOT bumped, i.e., there's no `global.set __stack_pointer` in the generated code. Isn't `__stack_pointer` here just used to compute the frame index?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59007/new/

https://reviews.llvm.org/D59007