[PATCH] D58998: Add declarations of explicit specializations and make primary template deleted
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 7 10:25:55 PST 2019
dblaikie added a comment.
In D58998#1419205 <https://reviews.llvm.org/D58998#1419205>, @jyknight wrote:
> Is there any reason this needs to be a template -- can't these just be changed to function overloads, instead of template specializations?
I'll second this - and I'm happy to take ownership (if it's needed) of the decision. This code came in with this specialization approach, and I'm going to guess it wasn't for any particularly nuanced reason & is fine to change to overloads as would be more common here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58998/new/
https://reviews.llvm.org/D58998
More information about the llvm-commits
mailing list