[PATCH] D59001: X86TargetLowering::LowerSELECT(): don't promote CMOV's if the subtarget does't have them

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 7 10:06:45 PST 2019


lebedev.ri abandoned this revision.
lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.

Okay, this isn't the right way indeed.
We likely want to keep that restriction for the new i8 case in D59035 <https://reviews.llvm.org/D59035> to
not regress existing cases, but in general we should always do this promotion.

Also, `EmitLoweredSelect()` needs to be fixed to accept some intermediate
instructions between two CMOV's, like in @scalar_i16_unsigned_reg_reg in this diff,


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59001/new/

https://reviews.llvm.org/D59001





More information about the llvm-commits mailing list