[PATCH] D59035: [X86] Promote i8 CMOV's (PR40965)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri updated this revision to Diff 189741.
lebedev.ri edited the summary of this revision.
lebedev.ri added a comment.

- Don't introduce `Subtarget.hasCMov()` requirement for i16 CMOV promotion.
- Do require `Subtarget.hasCMov()` for i8 CMOV promotion. We should not have that limitation, but EmitLoweredSelect() can not deal with these extensions being inserted between two CMOV's. That e.g. breaks `pseudo_cmov_lower.ll` test. PR40974 <https://bugs.llvm.org/show_bug.cgi?id=40974>


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59035/new/

https://reviews.llvm.org/D59035

Files:
  lib/Target/X86/X86ISelLowering.cpp
  test/CodeGen/X86/8bit_cmov_of_trunc_promotion.ll
  test/CodeGen/X86/cmov-promotion.ll
  test/CodeGen/X86/cmov.ll
  test/CodeGen/X86/cmovcmov.ll
  test/CodeGen/X86/copy-eflags.ll
  test/CodeGen/X86/fast-isel-select-pseudo-cmov.ll
  test/CodeGen/X86/fshl.ll
  test/CodeGen/X86/fshr.ll
  test/CodeGen/X86/i386-shrink-wrapping.ll
  test/CodeGen/X86/midpoint-int.ll
  test/CodeGen/X86/pr5145.ll
  test/CodeGen/X86/sadd_sat.ll
  test/CodeGen/X86/sadd_sat_vec.ll
  test/CodeGen/X86/sat-add.ll
  test/CodeGen/X86/select.ll
  test/CodeGen/X86/select_const.ll
  test/CodeGen/X86/ssub_sat.ll
  test/CodeGen/X86/ssub_sat_vec.ll
  test/CodeGen/X86/uadd_sat.ll
  test/CodeGen/X86/uadd_sat_vec.ll
  test/CodeGen/X86/usub_sat.ll
  test/CodeGen/X86/usub_sat_vec.ll
  test/CodeGen/X86/x86-shrink-wrapping.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59035.189741.patch
Type: text/x-patch
Size: 56250 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190307/af25a3e3/attachment.bin>