[PATCH] D59005: Fix memory leak in CreateSigAltStack

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 7 09:10:34 PST 2019


jfb added inline comments.


================
Comment at: llvm/lib/Support/Unix/Signals.inc:325
   // instead of recursing in the signal handler.
   UnregisterHandlers();
 
----------------
I think this is the root of your issue: the signal handlers are de-registered with the expectation that LLVM will never handle signals ever again. Clearly that's not true. What signals are being handled? i.e. to get the bug you're seeing, can you log `Sig` every time it occurs. What are they? Maybe we're installing non-fatal handlers (that's fine!) but then we can only unregister handlers for fatal signals, not for non-fatal ones.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59005/new/

https://reviews.llvm.org/D59005





More information about the llvm-commits mailing list